BZ#1886450: Added information for Keepalived router id check for RHV/VMware IPI #35316

dcdacosta · 2021-08-06T21:57:58Z

For ~~4.6~~ 4.8 to 4.10

https://bugzilla.redhat.com/show_bug.cgi?id=1886450

Direct links to preview changes:
https://deploy-preview-35316--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_rhv/preparing-to-install-on-rhv.html#keepalived-limitation-for-ipi_preparing-to-install-on-rhv

https://deploy-preview-35316--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_vsphere/preparing-to-install-on-vsphere.html#keepalived-limitation-for-ipi_preparing-to-install-on-vsphere

netlify · 2021-08-06T21:59:38Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 4aef9ca3b4f3d2f395f2d7b43198a44d0ebfb64f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6196e0a07eb3c80008c437e5

😎 Browse the preview: https://deploy-preview-35316--osdocs.netlify.app

Gal-Zaidman · 2021-08-08T14:54:17Z

At the current state, the entry is under Preparing to install on XXXXX.
I think this is way to early in the process and will either scare users or just make them ignore it.
Maybe this should be added in some global shard place and we should reference it on editing the install-config/answering the questions?
@janosdebugs @eslutsky you have a good customers perspective what do you think?

ghost · 2021-08-08T16:46:47Z

+1, this seems to be the wrong place to put this information. It would add a lengthy section between these two headings, making the user lose track of options:

dcdacosta · 2021-08-09T16:11:39Z

@Gal-Zaidman @janosdebugs
Would this information be better placed in the Networking Requirements (VSphere) and Preparing the Network Environment on RHV sections? Not sure about what would be a good "global shared place". Also, perhaps changing the title to something like "Identifying pre-existing Virtual Routers" might be less alarming to the customer? Once we decide on a location for the topic, I can link to it in the install-config/answering sections as suggested.

Any guidance is appreciated.

Gal-Zaidman · 2021-08-19T14:13:09Z

@Gal-Zaidman @janosdebugs
Would this information be better placed in the Networking Requirements (VSphere) and Preparing the Network Environment on RHV sections? Not sure about what would be a good "global shared place". Also, perhaps changing the title to something like "Identifying pre-existing Virtual Routers" might be less alarming to the customer? Once we decide on a location for the topic, I can link to it in the install-config/answering sections as suggested.

Any guidance is appreciated.

Sorry, I thought I replied to this PR but apparently, I didn't :)
So under the "Preparing the Network Environment" sounds ok.
I'll comment on the contant

modules/keepalived-limitation-for-ipi.adoc

Gal-Zaidman · 2021-08-19T15:44:43Z

@eslutsky @janosdebugs
Can you review the content of this Doc? it seems a bit confusing and to technical for most users (I think) maybe there is a way to improve it?

Gal-Zaidman · 2021-09-05T08:22:17Z

@dcdacosta what is the status on this PR?

dcdacosta · 2021-09-07T13:58:57Z

@dcdacosta what is the status on this PR?

@Gal-Zaidman I was waiting for @eslutsky and @janosdebugs to review the content based on your previous comment. I'll go ahead with the changes you suggested and update the PR today.

modules/keepalived-limitation-for-ipi.adoc

dcdacosta · 2021-09-22T16:51:04Z

@janosdebugs Unfortunately, I'm not sure. The information is included based on input from the original BZ. I've set the needinfo to Andrew Downs to get clarification.

ghost · 2021-09-22T16:54:09Z

@dcdacosta please see my email for further information I managed to dig up.

modules/keepalived-limitation-for-ipi.adoc

dcdacosta · 2021-09-29T23:36:50Z

@Gal-Zaidman @janosdebugs I included the latest updates but edited the text for the example to be action oriented. Instead of ...
""
Therefore one of the cluster names needs to be changed and the process needs to be repeated till there is no conflict
""
I rewrote to this:
""
To resolve this conflict, rename one of the clusters and repeat this procedure until the conflict is eliminated.
""
Let me know if everything is ok now or if other changes are required. Thanks very much!

Gal-Zaidman · 2021-10-06T07:22:32Z

/lgtm

bobfuru · 2021-10-12T17:14:37Z

Added labels but only back to enterprise-4.6, which is the oldest supported OCP 4 release at present.

bobfuru · 2021-11-19T16:56:54Z

Left a few more small follow-ups for you to PTAL, @dcdacosta - thanks!

openshift-bot · 2022-02-17T17:05:04Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

dcdacosta · 2022-02-17T17:10:47Z

/remove-lifecycle stale

openshift-bot · 2022-05-18T18:21:05Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

dcdacosta · 2022-05-18T18:26:46Z

/remove-lifecycle stale

EmilienM · 2022-06-01T19:34:15Z

modules/keepalived-limitation-for-ipi.adoc

in 4.11, this has switched to Unicast for all on-prem. see openshift/machine-config-operator#3016

mandre

Hi @dcdacosta, could you also add this recommendation for OpenStack as well?

All on-prem platforms (BM, OpenStack, RHV, and vSphere) share the same architecture, and the recommendation should be common to all. The conflicting VRIDs is an issue only when using keepalived in multicast mode.

BM uses keepalived with unicast mode at least since 4.6, so the recommendation would not apply to them.
The other platforms have switched to keepalived unicast in 4.11. We therefore need this doc change to cover OpenStack, RHV, and vSphere from 4.6 to 4.10, assuming 4.6 is the oldest version for which we're still maintaining docs.

mandre

Could you make the doc change for OpenStack as well?

kalexand-rh · 2022-10-27T14:34:15Z

Only versions 4.8+ are still in maintenance. I am removing labels from earlier versions from this PR.

openshift-bot · 2023-01-26T09:00:21Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-02-26T00:30:49Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2023-03-28T08:00:19Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2023-03-28T08:03:24Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2021

dcdacosta force-pushed the BZ#1886450 branch 3 times, most recently from 89f5303 to 395b4c5 Compare August 18, 2021 22:33

Gal-Zaidman reviewed Aug 19, 2021

View reviewed changes